findepi commented on PR #6608: URL: https://github.com/apache/arrow-rs/pull/6608#issuecomment-2427639487
Thank you @alamb @westonpace @tustvold for your time reviewing this! > I feel fairly strongly that we should not merge this, people will likely use this blindly without appreciating the severe performance penalty it entails. @tustvold Can you elaborate there the severe performance penalty comes from and what would it take to fix it? For DataFusion at least the alternative is to all `logical_nulls().map(|n| n.null_count())` which is strictly less performant than the alternative offered here. DataFusion will continue to use this slower path until a faster path exists -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
