findepi commented on code in PR #6608:
URL: https://github.com/apache/arrow-rs/pull/6608#discussion_r1809473926
##########
arrow-array/src/array/null_array.rs:
##########
@@ -116,8 +117,8 @@ impl Array for NullArray {
(self.len != 0).then(|| NullBuffer::new_null(self.len))
}
- fn is_nullable(&self) -> bool {
- !self.is_empty()
+ fn logical_null_count(&self) -> usize {
+ self.len
Review Comment:
I can retract changes in `is_nullable` function. I don't care about them.
I changed `is_nullable` because the implementation and documentation seemed
to disagree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
