tustvold commented on code in PR #6611:
URL: https://github.com/apache/arrow-rs/pull/6611#discussion_r1810341348
##########
arrow-integration-testing/src/flight_server_scenarios/integration_test.rs:
##########
@@ -48,9 +48,13 @@ type Result<T = (), E = Error> = std::result::Result<T, E>;
/// Run a scenario that tests integration testing.
pub async fn scenario_setup(port: u16) -> Result {
let addr = super::listen_on(port).await?;
+ let resolved_port = addr.port();
let service = FlightServiceImpl {
- server_location: format!("grpc+tcp://{addr}"),
+ // See https://github.com/apache/arrow-rs/issues/6577
Review Comment:
FWIW listen_on should probably be returning the resolved socket address.
Also localhost may not work on machines with dual stack IPv4 and IPv6, as
the latter will be preferred
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
