alamb commented on code in PR #6611:
URL: https://github.com/apache/arrow-rs/pull/6611#discussion_r1812473298
##########
arrow-integration-testing/src/flight_server_scenarios/integration_test.rs:
##########
@@ -48,9 +48,13 @@ type Result<T = (), E = Error> = std::result::Result<T, E>;
/// Run a scenario that tests integration testing.
pub async fn scenario_setup(port: u16) -> Result {
let addr = super::listen_on(port).await?;
+ let resolved_port = addr.port();
let service = FlightServiceImpl {
- server_location: format!("grpc+tcp://{addr}"),
+ // See https://github.com/apache/arrow-rs/issues/6577
Review Comment:
It looks like other places in the tests also use `localhost` as the hostname
here as well:
https://github.com/apache/arrow-rs/blob/7781bc2170c84ada387901e09b2cdfe4235c3570/arrow-integration-testing/src/flight_server_scenarios/middleware.rs#L103
So maybe this is a problem that we can address if someone has issues running
the tests on their environment. It "works for me" locally and it works on CI so
perhaps that is good enough
I'll wait a while longer to see if anyone else has any good ideas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
