alamb commented on code in PR #6611:
URL: https://github.com/apache/arrow-rs/pull/6611#discussion_r1812470309
##########
arrow-integration-testing/src/flight_server_scenarios/integration_test.rs:
##########
@@ -48,9 +48,13 @@ type Result<T = (), E = Error> = std::result::Result<T, E>;
/// Run a scenario that tests integration testing.
pub async fn scenario_setup(port: u16) -> Result {
let addr = super::listen_on(port).await?;
+ let resolved_port = addr.port();
let service = FlightServiceImpl {
- server_location: format!("grpc+tcp://{addr}"),
+ // See https://github.com/apache/arrow-rs/issues/6577
Review Comment:
I think my simple example from above does something like this (without the
TcpIncoming) (binds to `0.0.0.0` and then gets `local_addr`) but that still
seems to return 0.0.0.0
```rust
let addr: SocketAddr = format!("0.0.0.0:{port}").parse().unwrap();
let listener = TcpListener::bind(addr).unwrap();
let addr = listener.local_addr().unwrap();
```
It seems like this is what `listen_on` also tries to do 🤔
https://github.com/apache/arrow-rs/blob/7781bc2170c84ada387901e09b2cdfe4235c3570/arrow-integration-testing/src/flight_server_scenarios/mod.rs#L33-L38
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]