kou commented on PR #44503: URL: https://github.com/apache/arrow/pull/44503#issuecomment-2436545107
It's related: https://github.com/apache/arrow/actions/runs/11499533014/job/32034937833?pr=44503#step:7:6721 ```text g++ -std=gnu++17 -I"/usr/share/R/include" -DNDEBUG -I/usr/local/include -DARROW_R_WITH_PARQUET -DARROW_R_WITH_DATASET -DARROW_R_WITH_ACERO -DARROW_R_WITH_SUBSTRAIT -DARROW_R_WITH_JSON -DARROW_R_WITH_S3 -DARROW_R_WITH_GCS -Werror -I'/usr/local/lib/R/site-library/cpp11/include' -fpic -g -O2 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -ffile-prefix-map=/build/r-base-YnquTi/r-base-4.4.1=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fdebug-prefix-map=/build/r-base-YnquTi/r-base-4.4.1=/usr/src/r-base-4.4.1-3.2404.0 -Wdate-time -D_FORTIFY_SOURCE=3 -c type_infer.cpp -o type_infer.o filesystem.cpp: In function ‘std::shared_ptr<arrow::fs::GcsFileSystem> fs___GcsFileSystem__Make(bool, cpp11::list)’: filesystem.cpp:433:33: error: could not convert ‘arrow::fs::GcsFileSystem::Make(const arrow::fs::GcsOptions&, const arrow::io::IOContext&)(io_context)’ from ‘arrow::Result<std::shared_ptr<arrow::fs::GcsFileSystem> >’ to ‘std::shared_ptr<arrow::fs::GcsFileSystem>’ 433 | return fs::GcsFileSystem::Make(gcs_opts, io_context); | ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~ | | | arrow::Result<std::shared_ptr<arrow::fs::GcsFileSystem> > make: *** [/usr/lib/R/etc/Makeconf:204: filesystem.o] Error 1 ``` Hmm. It may be better that we keep the old signature with deprecation for easy to migration. Something like: ```diff diff --git a/cpp/src/arrow/filesystem/gcsfs.h b/cpp/src/arrow/filesystem/gcsfs.h index f1fbc95bf9..3789da18ec 100644 --- a/cpp/src/arrow/filesystem/gcsfs.h +++ b/cpp/src/arrow/filesystem/gcsfs.h @@ -231,10 +231,14 @@ class ARROW_EXPORT GcsFileSystem : public FileSystem { const std::shared_ptr<const KeyValueMetadata>& metadata) override; /// Create a GcsFileSystem instance from the given options. - // TODO(ARROW-16884): make this return Result for consistency + ARROW_DEPRECATED("Deprecated in 19.0.0. Use the Result version instead.") static std::shared_ptr<GcsFileSystem> Make( const GcsOptions& options, const io::IOContext& = io::default_io_context()); + /// Create a GcsFileSystem instance from the given options. + static Result<std::shared_ptr<GcsFileSystem>> Make( + const GcsOptions& options, const io::IOContext& = io::default_io_context()); + private: explicit GcsFileSystem(const GcsOptions& options, const io::IOContext& io_context); ``` FYI: You can check CI results on your for by enabling GitHub Actions on your fork. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
