kou commented on code in PR #44503: URL: https://github.com/apache/arrow/pull/44503#discussion_r1817930919
########## r/src/filesystem.cpp: ########## @@ -429,8 +429,8 @@ std::shared_ptr<fs::GcsFileSystem> fs___GcsFileSystem__Make(bool anonymous, } auto io_context = MainRThread::GetInstance().CancellableIOContext(); - // TODO(ARROW-16884): update when this returns Result - return fs::GcsFileSystem::Make(gcs_opts, io_context); + + return ValueOrStop(fs::GcsFileSystem::Make(gcs_opts, io_context)); Review Comment: OK. Then let's wait for 18.0.0 release. We will bump development version to 19 in the 18.0.0 release process. FYI: You can monitor https://lists.apache.org/thread/c3t7wn32pp506925fm1bg15lrrk4jrz6 thread for the 18.0.0 release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
