trifleneurotic commented on code in PR #44503: URL: https://github.com/apache/arrow/pull/44503#discussion_r1817890091
########## r/src/filesystem.cpp: ########## @@ -429,8 +429,8 @@ std::shared_ptr<fs::GcsFileSystem> fs___GcsFileSystem__Make(bool anonymous, } auto io_context = MainRThread::GetInstance().CancellableIOContext(); - // TODO(ARROW-16884): update when this returns Result - return fs::GcsFileSystem::Make(gcs_opts, io_context); + + return ValueOrStop(fs::GcsFileSystem::Make(gcs_opts, io_context)); Review Comment: Done! Ref b27686b4ccfb49171ca52596ab28734024696dcf (although I had to lower the major version to 18 to get workflow to finish). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
