bkietz commented on code in PR #43632:
URL: https://github.com/apache/arrow/pull/43632#discussion_r1816974645
##########
cpp/src/arrow/c/abi.h:
##########
@@ -356,8 +356,7 @@ struct ArrowAsyncDeviceStreamHandler {
// A producer that receives a non-zero return here should stop producing and
eventually
// call release instead.
int (*on_schema)(struct ArrowAsyncDeviceStreamHandler* self,
- struct ArrowAsyncProducer* producer, struct ArrowSchema*
stream_schema,
- const char* addl_metadata);
+ struct ArrowSchema* stream_schema, const char*
addl_metadata);
Review Comment:
If you already responded elsewhere then sorry for the noise, but I can't
find my own first comment on this: we could remove the ambiguity of what this
metadata pertains to by making it a member of `ArrowAsyncProducer`. This would
simplify this signature and remove the need to clarify `addl_metadata`'s
lifetime
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
