zeroshade commented on code in PR #43632:
URL: https://github.com/apache/arrow/pull/43632#discussion_r1821320534
##########
cpp/src/arrow/c/abi.h:
##########
@@ -356,8 +356,7 @@ struct ArrowAsyncDeviceStreamHandler {
// A producer that receives a non-zero return here should stop producing and
eventually
// call release instead.
int (*on_schema)(struct ArrowAsyncDeviceStreamHandler* self,
- struct ArrowAsyncProducer* producer, struct ArrowSchema*
stream_schema,
- const char* addl_metadata);
+ struct ArrowSchema* stream_schema, const char*
addl_metadata);
Review Comment:
While it would simplify the signature I'm not sure I necessarily like the
idea as far as the lifetime handling of it.
@pitrou @lidavidm @paleolimbot what are your thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
