lidavidm commented on code in PR #43632:
URL: https://github.com/apache/arrow/pull/43632#discussion_r1821689061
##########
cpp/src/arrow/c/abi.h:
##########
@@ -356,8 +356,7 @@ struct ArrowAsyncDeviceStreamHandler {
// A producer that receives a non-zero return here should stop producing and
eventually
// call release instead.
int (*on_schema)(struct ArrowAsyncDeviceStreamHandler* self,
- struct ArrowAsyncProducer* producer, struct ArrowSchema*
stream_schema,
- const char* addl_metadata);
+ struct ArrowSchema* stream_schema, const char*
addl_metadata);
Review Comment:
The metadata might not be available until after the callback anyways so
there'd instead be the question of when it's valid/invalid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
