tisonkun commented on code in PR #6652:
URL: https://github.com/apache/arrow-rs/pull/6652#discussion_r1822667313
##########
arrow-buffer/src/buffer/mutable.rs:
##########
@@ -387,6 +387,10 @@ impl MutableBuffer {
/// ```
#[inline]
pub fn extend_from_slice<T: ArrowNativeType>(&mut self, items: &[T]) {
+ if items.is_empty() {
Review Comment:
Also add this improvement since we'd at least call
`builder.append_value("");` to finish the write at the method added above.
Not sure if this "improvement" always valid but it seems highly possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
