andylokandy commented on code in PR #6652:
URL: https://github.com/apache/arrow-rs/pull/6652#discussion_r1822763778
##########
arrow-array/src/builder/generic_bytes_builder.rs:
##########
@@ -318,13 +316,50 @@ impl<O: OffsetSizeTrait> Write for
GenericStringBuilder<O> {
/// assert_eq!(array.value(0), b"foo");
/// assert_eq!(array.value(1), b"\x00\x01\x02");
/// ```
+///
+/// # Example incrementally writing bytes with `write_bytes`
+///
+/// ```
+/// # use std::io::Write;
+/// # use arrow_array::builder::GenericBinaryBuilder;
+/// let mut builder = GenericBinaryBuilder::<i32>::new();
+///
+/// // Write data in multiple `write_bytes` calls
+/// write!(builder, "foo").unwrap();
+/// write!(builder, "bar").unwrap();
+/// // The next call to append_value finishes the current string
+/// // including all previously written strings.
+/// builder.append_value("baz");
+///
+/// // Write second value with a single write call
+/// write!(builder, "v2").unwrap();
+/// // finish the value by calling append_value with an empty string
+/// builder.append_value("");
+///
+/// let array = builder.finish();
+/// assert_eq!(array.value(0), "foobarbaz".as_bytes());
+/// assert_eq!(array.value(1), "v2".as_bytes());
+/// ```
pub type GenericBinaryBuilder<O> = GenericByteBuilder<GenericBinaryType<O>>;
+impl<O: OffsetSizeTrait> std::io::Write for GenericBinaryBuilder<O> {
+ fn write(&mut self, bs: &[u8]) -> std::io::Result<usize> {
+ self.value_builder.append_slice(bs);
+ Ok(bs.len())
+ }
+
+ fn flush(&mut self) -> std::io::Result<()> {
+ Ok(())
+ }
+}
+
#[cfg(test)]
mod tests {
use super::*;
use crate::array::Array;
use crate::GenericStringArray;
+ use std::fmt::Write as FmtWrite;
+ use std::io::Write as IoWrite;
Review Comment:
```suggestion
use std::fmt::Write as _;
use std::io::Write as _;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
