waynexia commented on PR #6652:
URL: https://github.com/apache/arrow-rs/pull/6652#issuecomment-2447475717
From the API level: this looks kind of misleading to me. The proposed
`Write::write` or `write_bytes` makes `BinaryBuilder` closer to an opaque byte
container, shadowing the concept of `item` and `offset`. I.e., array built from
this API would contain only one element. Plus we don't have an API to "cut" the
bytes buffer, but need to call `builder.append_value("");` which looks a bit
hack.
How about considering something like `Vec::from_raw_parts`, which accepts
different buffers obviously and hence avoids the potential misunderstand?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
