jp0317 commented on code in PR #6738:
URL: https://github.com/apache/arrow-rs/pull/6738#discussion_r1847571249
##########
parquet/src/format.rs:
##########
@@ -1738,6 +1738,12 @@ impl crate::thrift::TSerializable for IntType {
bit_width: f_1.expect("auto-generated code should have checked for
presence of required fields"),
is_signed: f_2.expect("auto-generated code should have checked for
presence of required fields"),
};
+ if ret.bit_width != 8 && ret.bit_width != 16 && ret.bit_width != 32 &&
ret.bit_width != 64 {
Review Comment:
didn't notice that, thanks! I moved the checking to schema type.rs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]