jp0317 commented on code in PR #6738:
URL: https://github.com/apache/arrow-rs/pull/6738#discussion_r1849530795


##########
parquet/src/schema/types.rs:
##########
@@ -1227,6 +1231,10 @@ fn from_thrift_helper(elements: &[SchemaElement], index: 
usize) -> Result<(usize
                 if !is_root_node {
                     builder = builder.with_repetition(rep);
                 }
+            } else if !is_root_node {

Review Comment:
   > it breaks something for someone
   
   if it happened then someone must have already experienced panics. But i get 
your point, removed this change. thx



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to