jp0317 commented on PR #6738: URL: https://github.com/apache/arrow-rs/pull/6738#issuecomment-2484632213
Thanks @tustvold for the review! >this seems to add a number of untested additional checks... I think the changes are more about converting panics to errors, rather than actual code logic. > looking for things that might panic, instead going from a failing test to a fix these panics were triggered in my own fuzzing test with invalid parquet files. Nevertheless, i think it's a similar topic of "how to handle invalid inputs" as discussed in #5323. Reading this [doc](https://doc.rust-lang.org/book/ch09-03-to-panic-or-not-to-panic.html), imho errors better than panics unless it's really something unrecoverable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
