birschick-bq commented on code in PR #2312:
URL: https://github.com/apache/arrow-adbc/pull/2312#discussion_r1851105199
##########
csharp/src/Drivers/Apache/Spark/SparkHttpConnection.cs:
##########
@@ -164,7 +164,8 @@ protected override Task<TTransport> CreateTransportAsync()
TConfiguration config = new();
ThriftHttpTransport transport = new(httpClient, config)
{
- ConnectTimeout = HttpRequestTimeout,
+ // TODO: Remove support for HttpRequestTimeoutMilliseconds
+ //ConnectTimeout = HttpRequestTimeoutMilliseconds,
Review Comment:
That should be safe, for now. I'm sure many applications actaully update the
query timeout dynamically.
##########
csharp/src/Drivers/Apache/Spark/SparkHttpConnection.cs:
##########
@@ -164,7 +164,8 @@ protected override Task<TTransport> CreateTransportAsync()
TConfiguration config = new();
ThriftHttpTransport transport = new(httpClient, config)
{
- ConnectTimeout = HttpRequestTimeout,
+ // TODO: Remove support for HttpRequestTimeoutMilliseconds
+ //ConnectTimeout = HttpRequestTimeoutMilliseconds,
Review Comment:
That should be safe, for now. I'm sure many applications actually update the
query timeout dynamically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
