davidhcoe commented on code in PR #2312:
URL: https://github.com/apache/arrow-adbc/pull/2312#discussion_r1851083418
##########
csharp/src/Drivers/Apache/Spark/SparkHttpConnection.cs:
##########
@@ -164,7 +164,8 @@ protected override Task<TTransport> CreateTransportAsync()
TConfiguration config = new();
ThriftHttpTransport transport = new(httpClient, config)
{
- ConnectTimeout = HttpRequestTimeout,
+ // TODO: Remove support for HttpRequestTimeoutMilliseconds
+ //ConnectTimeout = HttpRequestTimeoutMilliseconds,
Review Comment:
I pushed changes to address the max of Connect/Query timeout. I don't think
we need to handle the dynamically changed value now, do we?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
