birschick-bq commented on code in PR #2312:
URL: https://github.com/apache/arrow-adbc/pull/2312#discussion_r1849477420
##########
csharp/src/Drivers/Apache/Spark/SparkHttpConnection.cs:
##########
@@ -164,7 +164,8 @@ protected override Task<TTransport> CreateTransportAsync()
TConfiguration config = new();
ThriftHttpTransport transport = new(httpClient, config)
{
- ConnectTimeout = HttpRequestTimeout,
+ // TODO: Remove support for HttpRequestTimeoutMilliseconds
+ //ConnectTimeout = HttpRequestTimeoutMilliseconds,
Review Comment:
If `ThriftHttpTransport.ConnectTimeout` is not set, it defaults to 30
seconds. Ideally, this should be the max of Connect/QueryTimeout. However, the
`QueryTimeout` can be updated after this setting is initially made. Luckily, it
is possible to update the value dynamically :
`Connection.Client.OutputProtocol.Transport as ThriftHttpTransport` - if it
uses SocketTransport, this will be `null`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
