kou commented on code in PR #44819:
URL: https://github.com/apache/arrow/pull/44819#discussion_r1855322405
##########
cpp/src/parquet/arrow/reader.h:
##########
@@ -116,15 +116,14 @@ class RowGroupReader;
class PARQUET_EXPORT FileReader {
public:
/// Factory function to create a FileReader from a ParquetFileReader and
properties
- static ::arrow::Status Make(::arrow::MemoryPool* pool,
- std::unique_ptr<ParquetFileReader> reader,
- const ArrowReaderProperties& properties,
- std::unique_ptr<FileReader>* out);
Review Comment:
Could you keep the `arrow::Status` version with deprecated mark so that
users will be able to migrate to the `arrow::Result` version smoothly?
See also: https://github.com/apache/arrow/pull/44785
##########
cpp/src/parquet/arrow/writer.h:
##########
@@ -53,10 +53,11 @@ namespace arrow {
/// file.
class PARQUET_EXPORT FileWriter {
public:
- static ::arrow::Status Make(MemoryPool* pool,
std::unique_ptr<ParquetFileWriter> writer,
- std::shared_ptr<::arrow::Schema> schema,
- std::shared_ptr<ArrowWriterProperties>
arrow_properties,
- std::unique_ptr<FileWriter>* out);
+ static ::arrow::Result<std::unique_ptr<FileReader>> Make(
+ MemoryPool* pool, std::unique_ptr<ParquetFileWriter> writer,
+ std::shared_ptr<::arrow::Schema> schema,
+ std::shared_ptr<ArrowWriterProperties> arrow_properties,
+ std::unique_ptr<FileWriter>* out);
Review Comment:
Could you work on this as a separated task?
##########
cpp/src/parquet/arrow/schema.h:
##########
@@ -104,7 +104,7 @@ struct PARQUET_EXPORT SchemaField {
/// Expose parquet columns as a tree structure. Useful traverse and link
/// between arrow's Schema and parquet's Schema.
struct PARQUET_EXPORT SchemaManifest {
- static ::arrow::Status Make(
+ static ::arrow::Result<std::unique_ptr<FileReader>> Make(
Review Comment:
Could you work on this as a separated task?
##########
cpp/src/parquet/bloom_filter.cc:
##########
@@ -77,7 +77,7 @@ void BlockSplitBloomFilter::Init(const uint8_t* bitset,
uint32_t num_bytes) {
static constexpr uint32_t kBloomFilterHeaderSizeGuess = 256;
-static ::arrow::Status ValidateBloomFilterHeader(
+static ::arrow::Result<std::unique_ptr<FileReader>> ValidateBloomFilterHeader(
Review Comment:
Could you work on this as a separated task?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
