tustvold commented on code in PR #6893:
URL: https://github.com/apache/arrow-rs/pull/6893#discussion_r1889289094
##########
arrow-select/src/concat.rs:
##########
@@ -169,6 +264,21 @@ pub fn concat(arrays: &[&dyn Array]) -> Result<ArrayRef,
ArrowError> {
_ => unreachable!("illegal dictionary key type {k}")
};
} else {
+ if let DataType::List(field) = d {
+ if let DataType::Dictionary(k, _) = field.data_type() {
+ downcast_integer! {
+ k.as_ref() => (list_dict_helper, i32, arrays),
+ _ => unreachable!("illegal dictionary key type {k}")
+ };
+ }
+ } else if let DataType::LargeList(field) = d {
+ if let DataType::Dictionary(k, _) = field.data_type() {
+ downcast_integer! {
+ k.as_ref() => (list_dict_helper, i64, arrays),
+ _ => unreachable!("illegal dictionary key type {k}")
+ };
+ }
+ }
Review Comment:
This is quite a lot of codegen for what is a relatively niche use-case, I'm
not sure we want to specialize this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
