tustvold commented on code in PR #6893:
URL: https://github.com/apache/arrow-rs/pull/6893#discussion_r1889294686
##########
arrow-select/src/concat.rs:
##########
@@ -169,6 +264,21 @@ pub fn concat(arrays: &[&dyn Array]) -> Result<ArrayRef,
ArrowError> {
_ => unreachable!("illegal dictionary key type {k}")
};
} else {
+ if let DataType::List(field) = d {
Review Comment:
It would be better to rework this into a match block
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
