rluvaton commented on code in PR #6893: URL: https://github.com/apache/arrow-rs/pull/6893#discussion_r1889984752
########## arrow-buffer/src/buffer/offset.rs: ########## @@ -162,6 +163,44 @@ impl<O: ArrowNativeType> OffsetBuffer<O> { } } +impl<O: ArrowNativeType + Integer + Copy> OffsetBuffer<O> { Review Comment: I also tried to make it more vectorized friendly (although not tested and I only have an idea how to do that as my low level knowledge is not great - do the same thing in a tight loop) I knew there was from length but because it can be a hot path I tried to make it as optimized as possible -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org