nealrichardson commented on a change in pull request #9745: URL: https://github.com/apache/arrow/pull/9745#discussion_r597995646
########## File path: r/R/expression.R ########## @@ -181,6 +181,20 @@ find_array_refs <- function(x) { unlist(out) } +get_field_name <- function(x, msg = NULL) { Review comment: This basically looks like the anonymous function inside of `map_chr` in `get_field_names()`. Whether or not you end up deciding that you need it here, you could factor that out as `get_field_name()` so it is usable in cases like this. (It also works on dataset Expressions, so you'll be set for supporting this feature on Datasets too.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org