nealrichardson commented on a change in pull request #9745:
URL: https://github.com/apache/arrow/pull/9745#discussion_r597971507
##########
File path: r/R/dplyr.R
##########
@@ -46,7 +46,12 @@ arrow_dplyr_query <- function(.data) {
# drop_empty_groups is a logical value indicating whether to drop
# groups formed by factor levels that don't appear in the data. It
# should be non-null only when the data is grouped.
- drop_empty_groups = NULL
+ drop_empty_groups = NULL,
+ # arrange_vars will be a list of expressions
+ arrange_vars = list(),
+ # arrange_desc will be a logical vector indicating the sort order for
each
+ # expression in arrange_vars (FALSE for ascending, TRUE for descending)
+ arrange_desc = logical()
Review comment:
Yeah I saw further down that you were trying to support arbitrary
expressions, so I guess then we have to treat these more like filter/mutate
than group_by.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
