ianmcook commented on a change in pull request #9745:
URL: https://github.com/apache/arrow/pull/9745#discussion_r597972335
##########
File path: r/R/dplyr.R
##########
@@ -390,6 +409,25 @@ collect.arrow_dplyr_query <- function(x, as_data_frame =
TRUE, ...) {
tab <- RecordBatch$create(!!!cols)
}
}
+ # Arrange rows
+ # TODO: support sorting by expressions, not just field names
Review comment:
Something like that, yes. But it might be cleaner to construct the
Vector of mutated values to sort on outside of the Table/RecordBatch so we
don't need to deal with column naming and removing it after. I'm still
experimenting with that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
