ngli-me commented on code in PR #6758:
URL: https://github.com/apache/arrow-rs/pull/6758#discussion_r1903203541
##########
arrow-array/src/record_batch.rs:
##########
@@ -1197,6 +1297,172 @@ mod tests {
assert_ne!(batch1, batch2);
}
+ #[test]
+ fn normalize_simple() {
+ let animals: ArrayRef = Arc::new(StringArray::from(vec!["Parrot",
""]));
+ let n_legs: ArrayRef = Arc::new(Int64Array::from(vec![Some(2),
Some(4)]));
+ let year: ArrayRef = Arc::new(Int64Array::from(vec![None,
Some(2022)]));
+
+ let animals_field = Arc::new(Field::new("animals", DataType::Utf8,
true));
+ let n_legs_field = Arc::new(Field::new("n_legs", DataType::Int64,
true));
+ let year_field = Arc::new(Field::new("year", DataType::Int64, true));
+
+ let a = Arc::new(StructArray::from(vec![
+ (animals_field.clone(), Arc::new(animals.clone()) as ArrayRef),
+ (n_legs_field.clone(), Arc::new(n_legs.clone()) as ArrayRef),
+ (year_field.clone(), Arc::new(year.clone()) as ArrayRef),
+ ]));
+
+ let month = Arc::new(Int64Array::from(vec![Some(4), Some(6)]));
+
+ let schema = Schema::new(vec![
+ Field::new(
+ "a",
+ DataType::Struct(Fields::from(vec![animals_field,
n_legs_field, year_field])),
+ false,
+ ),
+ Field::new("month", DataType::Int64, true),
+ ]);
+
+ let normalized = RecordBatch::try_new(Arc::new(schema), vec![a,
month.clone()])
+ .expect("valid conversion")
+ .normalize(".", 0)
+ .expect("valid normalization");
+
+ let expected = RecordBatch::try_from_iter_with_nullable(vec![
+ ("a.animals", animals.clone(), true),
+ ("a.n_legs", n_legs.clone(), true),
+ ("a.year", year.clone(), true),
+ ("month", month.clone(), true),
+ ])
+ .expect("valid conversion");
+
+ assert_eq!(expected, normalized);
+ }
+
+ #[test]
+ fn normalize_nested() {
Review Comment:
Good point, I'll work on these. I was a little hesitant since I'm not sure
how many cases I need to cover (also since these tests are really annoying to
instantiate), but it is a current blind spot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
