paleolimbot commented on code in PR #2546:
URL: https://github.com/apache/arrow-adbc/pull/2546#discussion_r1966887485
##########
c/CMakeLists.txt:
##########
@@ -29,9 +29,18 @@ set(CMAKE_CXX_STANDARD_REQUIRED ON)
include(CTest)
-add_subdirectory(vendor/fmt EXCLUDE_FROM_ALL)
-set_target_properties(fmt PROPERTIES POSITION_INDEPENDENT_CODE ON)
-add_subdirectory(vendor/nanoarrow)
+
+if(WITH_VENDORED_FMT)
Review Comment:
```suggestion
if(ADBC_WITH_VENDORED_FMT)
```
##########
c/driver/common/CMakeLists.txt:
##########
@@ -18,8 +18,12 @@
add_library(adbc_driver_common STATIC utils.c)
adbc_configure_target(adbc_driver_common)
set_target_properties(adbc_driver_common PROPERTIES POSITION_INDEPENDENT_CODE
ON)
-target_include_directories(adbc_driver_common PRIVATE
"${REPOSITORY_ROOT}/c/include"
-
"${REPOSITORY_ROOT}/c/vendor")
+target_include_directories(adbc_driver_common PRIVATE
"${REPOSITORY_ROOT}/c/include")
+if(WITH_VENDORED_NANOARROW)
Review Comment:
```suggestion
if(WITH_VENDORED_NANOARROW OR WITH_VENDORED_FMT)
```
maybe?
##########
c/CMakeLists.txt:
##########
@@ -29,9 +29,18 @@ set(CMAKE_CXX_STANDARD_REQUIRED ON)
include(CTest)
-add_subdirectory(vendor/fmt EXCLUDE_FROM_ALL)
-set_target_properties(fmt PROPERTIES POSITION_INDEPENDENT_CODE ON)
-add_subdirectory(vendor/nanoarrow)
+
+if(WITH_VENDORED_FMT)
+ add_subdirectory(vendor/fmt EXCLUDE_FROM_ALL)
+ set_target_properties(fmt PROPERTIES POSITION_INDEPENDENT_CODE ON)
+else()
+ find_package(fmt REQUIRED)
+endif()
+if(WITH_VENDORED_NANOARROW)
Review Comment:
```suggestion
if(ADBC_WITH_VENDORED_NANOARROW)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
