m-kuhn commented on code in PR #2546:
URL: https://github.com/apache/arrow-adbc/pull/2546#discussion_r1967059401
##########
c/driver/common/CMakeLists.txt:
##########
@@ -18,8 +18,12 @@
add_library(adbc_driver_common STATIC utils.c)
adbc_configure_target(adbc_driver_common)
set_target_properties(adbc_driver_common PROPERTIES POSITION_INDEPENDENT_CODE
ON)
-target_include_directories(adbc_driver_common PRIVATE
"${REPOSITORY_ROOT}/c/include"
-
"${REPOSITORY_ROOT}/c/vendor")
+target_include_directories(adbc_driver_common PRIVATE
"${REPOSITORY_ROOT}/c/include")
+if(WITH_VENDORED_NANOARROW)
Review Comment:
I believe fmt is only used once and properly linked by its target, so I
guess it does not depend on this include specification
https://github.com/apache/arrow-adbc/blob/8dade5b7e916a0df75b6c5abaf5493bafc4488f1/c/driver/framework/CMakeLists.txt#L26
We could nest nanoarrow a bit deeper to make this line explicit for nanoarrow
```
${REPOSITORY_ROOT}/c/include/nanoarrow"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
