paleolimbot commented on code in PR #2546:
URL: https://github.com/apache/arrow-adbc/pull/2546#discussion_r1967170973
##########
c/driver/common/CMakeLists.txt:
##########
@@ -18,8 +18,12 @@
add_library(adbc_driver_common STATIC utils.c)
adbc_configure_target(adbc_driver_common)
set_target_properties(adbc_driver_common PROPERTIES POSITION_INDEPENDENT_CODE
ON)
-target_include_directories(adbc_driver_common PRIVATE
"${REPOSITORY_ROOT}/c/include"
-
"${REPOSITORY_ROOT}/c/vendor")
+target_include_directories(adbc_driver_common PRIVATE
"${REPOSITORY_ROOT}/c/include")
+if(WITH_VENDORED_NANOARROW)
Review Comment:
Got it! We could also maybe better define the target in
`vendor/nanoarrow/CMakeLists.txt` (but no need to do that in this PR!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
