zeroshade commented on code in PR #2558:
URL: https://github.com/apache/arrow-adbc/pull/2558#discussion_r1969984742
##########
go/adbc/driver/snowflake/driver_test.go:
##########
@@ -66,7 +66,7 @@ func (s *SnowflakeQuirks) SetupDriver(t *testing.T)
adbc.Driver {
cfg.Schema = s.schemaName
s.connector = gosnowflake.NewConnector(gosnowflake.SnowflakeDriver{},
*cfg)
- return driver.NewDriver(s.mem)
+ return driver.NewDriver(s.mem,
driver.WithTransporter(gosnowflake.SnowflakeTransport))
Review Comment:
I'm a bit confused, it isn't already using the
`gosnowflake.SnowflakeTransport` under the hood? Honestly, my opinion is that
we should make this the default for our gosnowflake config rather than
introducing a Go only option in this way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
