frbvianna commented on code in PR #2558:
URL: https://github.com/apache/arrow-adbc/pull/2558#discussion_r1970203238
##########
go/adbc/driver/snowflake/driver.go:
##########
@@ -170,19 +171,30 @@ func quoteTblName(name string) string {
return "\"" + strings.ReplaceAll(name, "\"", "\"\"") + "\""
}
+type DriverOption func(*gosnowflake.Config) error
Review Comment:
This definition is open enough that users can implement their own
DriverOption funcs to change `*gosnowflake.Config` values arbitrarily.
Whether that is undesired may be arguable, but if it is a concern, we can
also create an unexported config struct that can both be extended and prevents
from users defining custom functions:
```suggestion
type config struct {
*gosnowflake.Config
}
type DriverOption func(*config) error
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
