raulcd commented on code in PR #45618:
URL: https://github.com/apache/arrow/pull/45618#discussion_r1970332510
##########
cpp/src/arrow/acero/CMakeLists.txt:
##########
@@ -64,10 +64,12 @@ if(ARROW_WITH_OPENTELEMETRY)
list(APPEND ARROW_ACERO_STATIC_LINK_LIBS ${ARROW_OPENTELEMETRY_LIBS})
endif()
-list(APPEND ARROW_ACERO_STATIC_INSTALL_INTERFACE_LIBS Arrow::arrow_static)
-list(APPEND ARROW_ACERO_SHARED_INSTALL_INTERFACE_LIBS Arrow::arrow_shared)
-list(APPEND ARROW_ACERO_STATIC_LINK_LIBS arrow_static)
-list(APPEND ARROW_ACERO_SHARED_LINK_LIBS arrow_shared)
+list(APPEND ARROW_ACERO_STATIC_INSTALL_INTERFACE_LIBS Arrow::arrow_static
+ ArrowCompute::arrow_compute_static)
+list(APPEND ARROW_ACERO_SHARED_INSTALL_INTERFACE_LIBS Arrow::arrow_shared
+ ArrowCompute::arrow_compute_shared)
+list(APPEND ARROW_ACERO_STATIC_LINK_LIBS arrow_static arrow_compute_static)
+list(APPEND ARROW_ACERO_SHARED_LINK_LIBS arrow_shared arrow_compute_shared)
Review Comment:
@kou this is a draft and still WIP (pretty far from being close to done as
there are lots of hacks to fix and I am not happy with the current registering
of kernels approach) but all the base C++ jobs are successful except one the
([AMD64 Windows 2019 C++17
AVX2](https://github.com/apache/arrow/actions/runs/13524975697/job/37799055758#logs)).
It currently works as seen on CI on the other C++ jobs (Windows mingw
included).
Do you know what am I missing so arrow_compute is correctly linked to Acero
on that job?
```
[350/620] Linking CXX shared library debug\arrow_acero.dll
FAILED: debug/arrow_acero.dll debug/arrow_acero.lib
C:\Windows\system32\cmd.exe /C "cd . && "C:\Program
Files\CMake\bin\cmake.exe" -E vs_link_dll --msvc-ver=1929
--intdir=src\arrow\acero\CMakeFiles\arrow_acero_shared.dir
--rc=C:\PROGRA~2\WI3CF2~1\10\bin\100226~1.0\x64\rc.exe
--mt=C:\PROGRA~2\WI3CF2~1\10\bin\100226~1.0\x64\mt.exe --manifests --
C:\PROGRA~2\MICROS~2\2019\ENTERP~1\VC\Tools\MSVC\1429~1.301\bin\Hostx64\x64\link.exe
/nologo
src\arrow\acero\CMakeFiles\arrow_acero_shared.dir\Unity\unity_3_cxx.cxx.obj
src\arrow\acero\CMakeFiles\arrow_acero_shared.dir\Unity\unity_2_cxx.cxx.obj
src\arrow\acero\CMakeFiles\arrow_acero_shared.dir\Unity\unity_1_cxx.cxx.obj
src\arrow\acero\CMakeFiles\arrow_acero_shared.dir\Unity\unity_0_cxx.cxx.obj
src\arrow\acero\CMakeFiles\arrow_acero_shared.dir\bloom_filter_avx2.cc.obj
src\arrow\acero\CMakeFiles\arrow_acero_shared.dir\swiss_join_avx2.cc.obj
/out:debug\arrow_acero.dll /implib:debug\arrow_acero.lib
/pdb:debug\arrow_acero.pdb /dll /version:2000.0 /machine:x64
/NODEFAULTLIB:LIBCMT /debug /INCREM
ENTAL debug\arrow_compute.lib debug\arrow.lib kernel32.lib user32.lib
gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib
advapi32.lib && cd ."
LINK Pass 1: command
"C:\PROGRA~2\MICROS~2\2019\ENTERP~1\VC\Tools\MSVC\1429~1.301\bin\Hostx64\x64\link.exe
/nologo
src\arrow\acero\CMakeFiles\arrow_acero_shared.dir\Unity\unity_3_cxx.cxx.obj
src\arrow\acero\CMakeFiles\arrow_acero_shared.dir\Unity\unity_2_cxx.cxx.obj
src\arrow\acero\CMakeFiles\arrow_acero_shared.dir\Unity\unity_1_cxx.cxx.obj
src\arrow\acero\CMakeFiles\arrow_acero_shared.dir\Unity\unity_0_cxx.cxx.obj
src\arrow\acero\CMakeFiles\arrow_acero_shared.dir\bloom_filter_avx2.cc.obj
src\arrow\acero\CMakeFiles\arrow_acero_shared.dir\swiss_join_avx2.cc.obj
/out:debug\arrow_acero.dll /implib:debug\arrow_acero.lib
/pdb:debug\arrow_acero.pdb /dll /version:2000.0 /machine:x64
/NODEFAULTLIB:LIBCMT /debug /INCREMENTAL debug\arrow_compute.lib
debug\arrow.lib kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib
ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST
/MANIFESTFILE:src\arrow\acero\CMakeFiles\arrow_acero_shared.dir/intermediate.manifest
src\arrow\acero\
CMakeFiles\arrow_acero_shared.dir/manifest.res" failed (exit code 1104) with
the following output:
LINK : fatal error LNK1104: cannot open file 'debug\arrow_compute.lib'
```
I wanted to fix that job and have a successful CI pass before starting to
clean up and fix some of the issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
