kou commented on code in PR #45618:
URL: https://github.com/apache/arrow/pull/45618#discussion_r1970728650
##########
cpp/src/arrow/acero/CMakeLists.txt:
##########
@@ -64,10 +64,12 @@ if(ARROW_WITH_OPENTELEMETRY)
list(APPEND ARROW_ACERO_STATIC_LINK_LIBS ${ARROW_OPENTELEMETRY_LIBS})
endif()
-list(APPEND ARROW_ACERO_STATIC_INSTALL_INTERFACE_LIBS Arrow::arrow_static)
-list(APPEND ARROW_ACERO_SHARED_INSTALL_INTERFACE_LIBS Arrow::arrow_shared)
-list(APPEND ARROW_ACERO_STATIC_LINK_LIBS arrow_static)
-list(APPEND ARROW_ACERO_SHARED_LINK_LIBS arrow_shared)
+list(APPEND ARROW_ACERO_STATIC_INSTALL_INTERFACE_LIBS Arrow::arrow_static
+ ArrowCompute::arrow_compute_static)
+list(APPEND ARROW_ACERO_SHARED_INSTALL_INTERFACE_LIBS Arrow::arrow_shared
+ ArrowCompute::arrow_compute_shared)
+list(APPEND ARROW_ACERO_STATIC_LINK_LIBS arrow_static arrow_compute_static)
+list(APPEND ARROW_ACERO_SHARED_LINK_LIBS arrow_shared arrow_compute_shared)
Review Comment:
Could you try defining `ARROW_COMPUTE_EXPORT` and using it instead of
removing `ARROW_EXPORT`?
`.lib` isn't generated when no symbols are exported.
##########
cpp/src/arrow/CMakeLists.txt:
##########
@@ -791,39 +793,89 @@ if(ARROW_COMPUTE)
compute/util.cc
compute/util_internal.cc)
- append_runtime_avx2_src(ARROW_COMPUTE_SRCS
compute/kernels/aggregate_basic_avx2.cc)
- append_runtime_avx512_src(ARROW_COMPUTE_SRCS
compute/kernels/aggregate_basic_avx512.cc)
- append_runtime_avx2_src(ARROW_COMPUTE_SRCS compute/key_hash_internal_avx2.cc)
- append_runtime_avx2_bmi2_src(ARROW_COMPUTE_SRCS
compute/key_map_internal_avx2.cc)
- append_runtime_avx2_src(ARROW_COMPUTE_SRCS
compute/row/compare_internal_avx2.cc)
- append_runtime_avx2_src(ARROW_COMPUTE_SRCS
compute/row/encode_internal_avx2.cc)
- append_runtime_avx2_bmi2_src(ARROW_COMPUTE_SRCS compute/util_avx2.cc)
+ append_runtime_avx2_src(ARROW_COMPUTE_LIB_SRCS
compute/kernels/aggregate_basic_avx2.cc)
+ append_runtime_avx512_src(ARROW_COMPUTE_LIB_SRCS
+ compute/kernels/aggregate_basic_avx512.cc)
+ append_runtime_avx2_src(ARROW_COMPUTE_LIB_SRCS
compute/key_hash_internal_avx2.cc)
+ append_runtime_avx2_bmi2_src(ARROW_COMPUTE_LIB_SRCS
compute/key_map_internal_avx2.cc)
+ append_runtime_avx2_src(ARROW_COMPUTE_LIB_SRCS
compute/row/compare_internal_avx2.cc)
+ append_runtime_avx2_src(ARROW_COMPUTE_LIB_SRCS
compute/row/encode_internal_avx2.cc)
+ append_runtime_avx2_bmi2_src(ARROW_COMPUTE_LIB_SRCS compute/util_avx2.cc)
+ # TODO: Some of those should be added conditionally
+ set(ARROW_COMPUTED_SHARED_PRIVATE_LINK_LIBS Boost::headers ${ARROW_XSIMD}
Review Comment:
```suggestion
set(ARROW_COMPUTE_SHARED_PRIVATE_LINK_LIBS Boost::headers ${ARROW_XSIMD}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
