raulcd commented on code in PR #45618:
URL: https://github.com/apache/arrow/pull/45618#discussion_r1971395064
##########
cpp/src/arrow/CMakeLists.txt:
##########
@@ -791,39 +793,89 @@ if(ARROW_COMPUTE)
compute/util.cc
compute/util_internal.cc)
- append_runtime_avx2_src(ARROW_COMPUTE_SRCS
compute/kernels/aggregate_basic_avx2.cc)
- append_runtime_avx512_src(ARROW_COMPUTE_SRCS
compute/kernels/aggregate_basic_avx512.cc)
- append_runtime_avx2_src(ARROW_COMPUTE_SRCS compute/key_hash_internal_avx2.cc)
- append_runtime_avx2_bmi2_src(ARROW_COMPUTE_SRCS
compute/key_map_internal_avx2.cc)
- append_runtime_avx2_src(ARROW_COMPUTE_SRCS
compute/row/compare_internal_avx2.cc)
- append_runtime_avx2_src(ARROW_COMPUTE_SRCS
compute/row/encode_internal_avx2.cc)
- append_runtime_avx2_bmi2_src(ARROW_COMPUTE_SRCS compute/util_avx2.cc)
+ append_runtime_avx2_src(ARROW_COMPUTE_LIB_SRCS
compute/kernels/aggregate_basic_avx2.cc)
+ append_runtime_avx512_src(ARROW_COMPUTE_LIB_SRCS
+ compute/kernels/aggregate_basic_avx512.cc)
+ append_runtime_avx2_src(ARROW_COMPUTE_LIB_SRCS
compute/key_hash_internal_avx2.cc)
+ append_runtime_avx2_bmi2_src(ARROW_COMPUTE_LIB_SRCS
compute/key_map_internal_avx2.cc)
+ append_runtime_avx2_src(ARROW_COMPUTE_LIB_SRCS
compute/row/compare_internal_avx2.cc)
+ append_runtime_avx2_src(ARROW_COMPUTE_LIB_SRCS
compute/row/encode_internal_avx2.cc)
+ append_runtime_avx2_bmi2_src(ARROW_COMPUTE_LIB_SRCS compute/util_avx2.cc)
+ # TODO: Some of those should be added conditionally
+ set(ARROW_COMPUTED_SHARED_PRIVATE_LINK_LIBS Boost::headers ${ARROW_XSIMD}
Review Comment:
oops, typo thanks :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
