wgtmac commented on code in PR #45685:
URL: https://github.com/apache/arrow/pull/45685#discussion_r1983650686
##########
cpp/src/parquet/arrow/schema.cc:
##########
@@ -989,8 +989,8 @@ Result<bool> ApplyOriginalStorageMetadata(const Field&
origin_field,
// so no need to recurse on value types.
const auto& dict_origin_type =
checked_cast<const ::arrow::DictionaryType&>(*origin_type);
- inferred->field = inferred->field->WithType(
- ::arrow::dictionary(::arrow::int32(), inferred_type,
dict_origin_type.ordered()));
+ inferred->field = inferred->field->WithType(::arrow::dictionary(
Review Comment:
I think this fix makes sense, though it might introduce a benign breaking
change to the downstream users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
