pitrou commented on code in PR #45685:
URL: https://github.com/apache/arrow/pull/45685#discussion_r1983649067
##########
cpp/src/parquet/arrow/arrow_reader_writer_test.cc:
##########
@@ -3336,6 +3336,26 @@ TEST(TestArrowReadWrite, NonUniqueDictionaryValues) {
}
}
+TEST(TestArrowReadWrite, DictionaryIndexBitwidthRoundtrip) {
+ auto dict_type = ::arrow::dictionary(::arrow::int8(), ::arrow::utf8());
Review Comment:
Let's perhaps be nifty and check all possible index types? Something like:
```suggestion
for (auto index_type : {int8(), int16(), int32(), int64()}) {
ARROW_SCOPED_TRACE("index_type = " , *index_type);
auto dict_type = ::arrow::dictionary(index_type, ::arrow::utf8());
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
