eli-schwartz commented on code in PR #45854: URL: https://github.com/apache/arrow/pull/45854#discussion_r2001966515
########## python/meson.build: ########## @@ -0,0 +1,71 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +project( + 'pyarrow', + 'cpp', + 'cython', + license: 'Apache-2.0', + meson_version: '>=1.4.0', + default_options: ['warning_level=2', 'cpp_std=c++17'], +) + +cmake = import('cmake') +cmake_opt = cmake.subproject_options() Review Comment: What this does: - check build options for wrap_mode, which is a builtin meson option allowing you to choose whether you wish to resolve bundled dependencies or look for system dependencies. It defaults to finding system dependencies, but when users run meson with `--wrap-mode=forcefallback` they are asking to explicitly avoid system deps - first try to find an arrow dependency, using both names it might be available as: - "arrow" (pkgconfig) - "Arrow" (cmake, yes capitalization does matter), with `modules:` ensuring we pick up the correct cmake find_package() variable - if it is not available, `required: false` means we continue to import the cmake subproject as a fallback -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
