eli-schwartz commented on code in PR #45854: URL: https://github.com/apache/arrow/pull/45854#discussion_r2002087518
########## python/meson.build: ########## @@ -0,0 +1,71 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +project( + 'pyarrow', + 'cpp', + 'cython', + license: 'Apache-2.0', + meson_version: '>=1.4.0', + default_options: ['warning_level=2', 'cpp_std=c++17'], +) + +cmake = import('cmake') +cmake_opt = cmake.subproject_options() Review Comment: Since you included a symlink anyway, I chose not to bother including any mechanism for downloading the wrap contents. Meson skips over that because the directory already exists with the correct content. The key benefit of the wrap file is that it allows specifying in `ini` syntax: - the subproject should use the `method=cmake` automatically, when used via `dependency()` - the autogenerated `arrow_static_dep` (maybe this should be `arrow_shared_dep` instead?) will fulfill `dependency('arrow')` Again, it's missing the necessary cmake defines so it may not be worth pursuing further. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
