westonpace commented on a change in pull request #9607:
URL: https://github.com/apache/arrow/pull/9607#discussion_r604066249
##########
File path: cpp/src/arrow/dataset/file_parquet.cc
##########
@@ -85,13 +85,16 @@ class ParquetScanTask : public ScanTask {
// since it must outlive the wrapped RecordBatchReader
std::shared_ptr<parquet::arrow::FileReader> file_reader;
std::unique_ptr<RecordBatchReader> record_batch_reader;
- } NextBatch;
+ };
+ auto next_batch = std::make_shared<GetNextBatch>();
Review comment:
Same as above, I'm attempting to keep the IPC/Parquet implementation as
true to the original as possible and they can be made asynchronous in a future
PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
