westonpace commented on a change in pull request #9607:
URL: https://github.com/apache/arrow/pull/9607#discussion_r605157413
##########
File path: cpp/src/arrow/dataset/dataset.h
##########
@@ -191,9 +200,9 @@ class ARROW_DS_EXPORT InMemoryDataset : public Dataset {
std::shared_ptr<Schema> schema) const override;
protected:
- Result<FragmentIterator> GetFragmentsImpl(Expression predicate) override;
+ Future<FragmentVector> GetFragmentsImpl(Expression predicate) override;
Review comment:
I was going to let this be addressed by ARROW-8163.
However, if we're getting ARROW-10882 done first then rather than go with an
InMemoryFragment approach I'd recommend switching to AsyncGenerator<Fragment>
at that point since we're going to do so sooner or later anyways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
