westonpace commented on a change in pull request #9607:
URL: https://github.com/apache/arrow/pull/9607#discussion_r605160946
##########
File path: cpp/src/arrow/dataset/dataset.h
##########
@@ -191,9 +200,9 @@ class ARROW_DS_EXPORT InMemoryDataset : public Dataset {
std::shared_ptr<Schema> schema) const override;
protected:
- Result<FragmentIterator> GetFragmentsImpl(Expression predicate) override;
+ Future<FragmentVector> GetFragmentsImpl(Expression predicate) override;
Review comment:
Also, it hopefully won't be too much work. The scanner already consumes
the FragmentVector as a generator so the only change needed would be to push
the MakeVectorGenerator down into the file formats.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
