adamreeve commented on code in PR #7111:
URL: https://github.com/apache/arrow-rs/pull/7111#discussion_r2010846626
##########
parquet/src/file/writer.rs:
##########
@@ -699,34 +803,61 @@ impl<'a> SerializedColumnWriter<'a> {
/// `SerializedPageWriter` should not be used after calling `close()`.
pub struct SerializedPageWriter<'a, W: Write> {
sink: &'a mut TrackedWrite<W>,
+ #[cfg(feature = "encryption")]
+ page_encryptor: Option<PageEncryptor>,
+ #[cfg(not(feature = "encryption"))]
+ page_encryptor: Option<Never>,
Review Comment:
I tried something a bit like this in
https://github.com/apache/arrow-rs/pull/7111#discussion_r1992613117 (see
https://github.com/adamreeve/arrow-rs/commit/c94ddd07f95ff09076019e8854f4d9f1f065683a),
but ran into an issue with my trait not being dyn-compatible. But making this
a compile-time switch rather than a dynamic trait object would avoid that
problem, I'll give this a go thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
