adamreeve commented on code in PR #7111: URL: https://github.com/apache/arrow-rs/pull/7111#discussion_r2011211923
########## parquet/src/file/writer.rs: ########## @@ -523,12 +595,37 @@ impl<'a, W: Write + Send> SerializedRowGroupWriter<'a, W> { ) -> Result<C>, { self.assert_previous_writer_closed()?; + + #[cfg(feature = "encryption")] Review Comment: I've tidied this particular method up. It was a bit awkward due to `get_on_close` returning a mutable reference from self so we can't call any other methods that take `&self` after this, but I think it has ended up cleaner. I'll continue trying to tidy up uses of `FileEncryptor` too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org