lidavidm commented on code in PR #45932: URL: https://github.com/apache/arrow/pull/45932#discussion_r2013046793
########## python/pyarrow/src/arrow/python/flight.cc: ########## @@ -37,7 +37,8 @@ PyServerAuthHandler::PyServerAuthHandler(PyObject* handler, handler_.reset(handler); } -Status PyServerAuthHandler::Authenticate(arrow::flight::ServerAuthSender* outgoing, +Status PyServerAuthHandler::Authenticate(const arrow::flight::ServerCallContext& context, + arrow::flight::ServerAuthSender* outgoing, Review Comment: Yeah, we would have to update the Python API as well (and do a similar deprecation cycle) ########## python/pyarrow/src/arrow/python/flight.cc: ########## @@ -37,7 +37,8 @@ PyServerAuthHandler::PyServerAuthHandler(PyObject* handler, handler_.reset(handler); } -Status PyServerAuthHandler::Authenticate(arrow::flight::ServerAuthSender* outgoing, +Status PyServerAuthHandler::Authenticate(const arrow::flight::ServerCallContext& context, + arrow::flight::ServerAuthSender* outgoing, Review Comment: That said if there's not demand for it we can just leave it as-is for now... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
