AlenkaF commented on code in PR #45932: URL: https://github.com/apache/arrow/pull/45932#discussion_r2016546565
########## python/pyarrow/src/arrow/python/flight.cc: ########## @@ -37,7 +37,8 @@ PyServerAuthHandler::PyServerAuthHandler(PyObject* handler, handler_.reset(handler); } -Status PyServerAuthHandler::Authenticate(arrow::flight::ServerAuthSender* outgoing, +Status PyServerAuthHandler::Authenticate(const arrow::flight::ServerCallContext& context, + arrow::flight::ServerAuthSender* outgoing, Review Comment: Leaving it as-is for now (the Python part) makes sense. The issue is that the `Authenticate` method in `PyServerAuthHandler` is overriding the one in C++ and so the signatures have to match already, _I think_. Maybe I can do a deprecation cycle for the Python part and leave this PR open till we are ready to remove it all? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
