AlenkaF commented on code in PR #45932:
URL: https://github.com/apache/arrow/pull/45932#discussion_r2016708226
##########
python/pyarrow/src/arrow/python/flight.cc:
##########
@@ -37,7 +37,8 @@ PyServerAuthHandler::PyServerAuthHandler(PyObject* handler,
handler_.reset(handler);
}
-Status PyServerAuthHandler::Authenticate(arrow::flight::ServerAuthSender*
outgoing,
+Status PyServerAuthHandler::Authenticate(const
arrow::flight::ServerCallContext& context,
+ arrow::flight::ServerAuthSender*
outgoing,
Review Comment:
No, I get errors when building PyArrow:
```
In file included from
/Users/alenkafrim/Repos/arrow/python/pyarrow/src/arrow/python/flight.cc:21:
/Users/alenkafrim/Repos/arrow/python/pyarrow/src/arrow/python/flight.h:118:66:
error: non-virtual member function marked 'override' hides virtual member
function
arrow::flight::ServerAuthReader* incoming) override;
^
/Users/alenkafrim/Repos/dist/include/arrow/flight/server_auth.h:63:18: note:
hidden overloaded virtual function
'arrow::flight::ServerAuthHandler::Authenticate' declared here: different
number of parameters (3 vs 2)
virtual Status Authenticate(const ServerCallContext& context,
^
In file included from
/Users/alenkafrim/Repos/arrow/python/pyarrow/src/arrow/python/flight.cc:21:
/Users/alenkafrim/Repos/arrow/python/pyarrow/src/arrow/python/flight.h:229:82:
error: non-virtual member function marked 'override' hides virtual member
function
std::shared_ptr<arrow::flight::ServerMiddleware>*
middleware) override;
^
/Users/alenkafrim/Repos/dist/include/arrow/flight/server_middleware.h:77:18:
note: hidden overloaded virtual function
'arrow::flight::ServerMiddlewareFactory::StartCall' declared here: type
mismatch at 2nd parameter ('const ServerCallContext &' vs 'const
arrow::flight::CallHeaders &' (aka 'const multimap<basic_string_view<char>,
basic_string_view<char>> &'))
virtual Status StartCall(const CallInfo& info, const ServerCallContext&
context,
^
/Users/alenkafrim/Repos/arrow/python/pyarrow/src/arrow/python/flight.cc:40:29:
error: out-of-line definition of 'Authenticate' does not match any declaration
in 'arrow::py::flight::PyServerAuthHandler'
Status PyServerAuthHandler::Authenticate(const
arrow::flight::ServerCallContext& context,
^~~~~~~~~~~~
3 errors generated.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
