alamb opened a new pull request, #7337: URL: https://github.com/apache/arrow-rs/pull/7337
# Which issue does this PR close? - Related to https://github.com/apache/arrow-rs/pull/6921 - Related to https://github.com/apache/arrow-rs/pull/7111 # Rationale for this change While trying to get the filter pushdown code in https://github.com/apache/arrow-rs/pull/6921 working, I keep hitting merge conflicts with encryption changes related to `#cfg[encryption]` Also I had an idea described in https://github.com/apache/arrow-rs/pull/7111#discussion_r2010832137 but I don't think I did a good job explaining it and it didn't seem to work for @adamreeve (see https://github.com/apache/arrow-rs/pull/7111#issuecomment-2753181854) Thus I would like to propose a pattern of how to reduce some duplication and keep the encryption related code out of the main deocder logic # What changes are included in this PR? Move adding `CryptoContext` into a method on `SerializedPageReader` # Are there any user-facing changes? No, this is all internal code reorganization <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!--- If there are any breaking changes to public APIs, please call them out. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
