alamb commented on code in PR #7337:
URL: https://github.com/apache/arrow-rs/pull/7337#discussion_r2014869944
##########
parquet/src/arrow/async_reader/mod.rs:
##########
@@ -1038,31 +1036,19 @@ impl RowGroups for InMemoryRowGroup<'_> {
// filter out empty offset indexes (old versions specified
Some(vec![]) when no present)
.filter(|index| !index.is_empty())
.map(|index| index[i].page_locations.clone());
- let column_metadata =
self.metadata.row_group(self.row_group_idx).column(i);
+ let column_chunk_metadata =
self.metadata.row_group(self.row_group_idx).column(i);
let page_reader = SerializedPageReader::new(
data.clone(),
- column_metadata,
+ column_chunk_metadata,
self.row_count,
page_locations,
)?;
-
- #[cfg(feature = "encryption")]
- let crypto_context = if let Some(file_decryptor) =
self.metadata.file_decryptor() {
- match column_metadata.crypto_metadata() {
- Some(crypto_metadata) =>
Some(Arc::new(CryptoContext::for_column(
- file_decryptor,
- crypto_metadata,
- self.row_group_idx,
- i,
- )?)),
- None => None,
- }
- } else {
- None
- };
-
- #[cfg(feature = "encryption")]
- let page_reader =
page_reader.with_crypto_context(crypto_context);
+ let page_reader = page_reader.add_crypto_context(
Review Comment:
same thing here, I removed the duplicated setup of the `CryptoContext` and
put it in a method on the page reader
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
